Simplified some code #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orashi
requested changes
Jun 23, 2017
| @@ -130,8 +134,7 @@ def api_mac_post(): | |||
| return '["false","unknown"]' | |||
|
|
|||
| try: | |||
| conn = psycopg2.connect(database="sunhaobomac", user="postgres", password="postgres", host="127.0.0.1", | |||
| port="5432") | |||
| conn = psycopg2.connect(database="sunhaobomac", user="postgre", password="postgre", host="127.0.0.1", port="5432") | |||
There was a problem hiding this comment.
Actually "postgres" is the default username and password for PostgreSQL so maybe we should leave it as before since this is going public, name for the database will be fixed maybe later.
There was a problem hiding this comment.
yeah, I forgot this point.
zsyh
reviewed
Jun 23, 2017
|
Thanks for the compliment and the PR! But the details are still under discussion, I'm sure these will come up recently by @Arbusz |
zsyh
reviewed
Jun 23, 2017
|
|
||
| app = Flask(__name__) | ||
| DEBUG=True |
There was a problem hiding this comment.
debug mode should NOT be opened in production environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brilliant idea.
Could you briefly introduce the structure of this project?
Could you create a config file for database account, password, binding port, etc.?